Ensure endpoint names are unique to avoid failures later in execution.#4071
Merged
mitchdenny merged 4 commits intomainfrom May 15, 2024
Merged
Ensure endpoint names are unique to avoid failures later in execution.#4071mitchdenny merged 4 commits intomainfrom
mitchdenny merged 4 commits intomainfrom
Conversation
ghost
added
the
area-app-model
mitchdenny
added
area-app-model
davidfowl
reviewed
May 3, 2024
This was referenced May 8, 2024
timheuer
reviewed
May 9, 2024
timheuer
reviewed
May 9, 2024
dotnet-policy-service
Bot
added
the
needs-author-action
Member
Author
|
@timheuer thanks for spotting those! |
dotnet-policy-service
Bot
removed
the
needs-author-action
Member
Author
|
@timheuer can you reset your vote? |
timheuer
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon changes in #4064
Moves the uniqueness check until after the endpoint is constructed and name is derived (to share the various bits of fallback logic).
Added a test case to cover this.
Microsoft Reviewers: Open in CodeFlow