Skip to content

Make credscan run clean #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 3 commits into from
Jul 12, 2024
Merged

Make credscan run clean #4876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad41c4f
suppressions
danmoseley Jul 12, 2024
d559f73
more
danmoseley Jul 12, 2024
74aa3a9
typo
danmoseley Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .config/CredScanSuppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@
{
"placeholder": "thisIsAFakeSecret",
"_justification": "This isn't a real secret, it's used in one of the playground applications for testing purposes."
},
{
"file": "\\tests\\Shared\\TestCertificates\\eku.client.pfx",
"_justification": "Legitimate UT certificate file with private key, from dotnet/aspnetcore"
},
{
"file": "\\tests\\Shared\\TestCertificates\\testCert.pfx",
"_justification": "Legitimate UT certificate file with private key, from dotnet/aspnetcore"
}
]
}
4 changes: 4 additions & 0 deletions tests/Shared/TestCertificates/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@
Unless otherwise stated, these certificates are copied from dotnet/aspnetcore:

https://github.com/dotnet/aspnetcore/tree/main/src/Shared/TestCertificates

If you add more, please also copy the suppression entries from this file in dotnet/aspnetcore:

.config\CredScanSuppressions.json