Skip to content

Add another column to the volume datagrid for mount type#6856

Merged
adamint merged 5 commits intomicrosoft:mainfrom
adamint:dev/adamint/add-custom-volume-datagrid
Dec 10, 2024
Merged

Add another column to the volume datagrid for mount type#6856
adamint merged 5 commits intomicrosoft:mainfrom
adamint:dev/adamint/add-custom-volume-datagrid

Conversation

@adamint
Copy link
Copy Markdown
Member

@adamint adamint commented Dec 2, 2024

Description

Replaces the old PropertyGrid for volumes in resource details with a new data grid with three columns.

Before
image

After
read only volume:
image

non-read only volume:
image

Fixes #6444

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No, not relevant
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@adamint adamint requested review from JamesNK and drewnoakes December 2, 2024 19:44
Comment thread src/Aspire.Dashboard/Components/Controls/ResourceDetails.razor Outdated
Comment thread src/Aspire.Dashboard/Components/Controls/ResourceDetails.razor Outdated
# Conflicts:
#	src/Aspire.Dashboard/wwwroot/css/app.css
@adamint adamint enabled auto-merge (squash) December 10, 2024 16:01
@adamint adamint merged commit 2fd58e4 into microsoft:main Dec 10, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use custom grid for resource volumes

2 participants