Skip to content

Fallback to observed time on OTLP logs#6994

Merged
JamesNK merged 2 commits intomainfrom
jamesnk/observedtime
Jan 4, 2025
Merged

Fallback to observed time on OTLP logs#6994
JamesNK merged 2 commits intomainfrom
jamesnk/observedtime

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Dec 29, 2024

Description

Fixes #6895

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK added area-dashboard area-telemetry Telemetry from the Aspire app to the dashboard labels Dec 29, 2024
Copy link
Copy Markdown
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JamesNK JamesNK force-pushed the jamesnk/observedtime branch from 6817753 to 212171a Compare January 3, 2025 02:03
@JamesNK JamesNK enabled auto-merge (squash) January 3, 2025 02:18
@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Jan 3, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK merged commit 951ffe5 into main Jan 4, 2025
@JamesNK JamesNK deleted the jamesnk/observedtime branch January 4, 2025 05:28
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-dashboard area-telemetry Telemetry from the Aspire app to the dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ObservedTimeUnixNano Fallback for Missing TimeUnixNano Field

2 participants