Skip to content

Fix resource filter UI#7079

Merged
JamesNK merged 1 commit intomainfrom
jamesnk/fix-resource-filter
Jan 14, 2025
Merged

Fix resource filter UI#7079
JamesNK merged 1 commit intomainfrom
jamesnk/fix-resource-filter

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Jan 13, 2025

Description

I noticed that the resources page didn't update the displayed resources with the search filter unless the underlying data changed.

PR updates to search filter change event to call refresh data on the data grid. This forces the data grid to refresh with matching resources.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Copy Markdown
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Jan 14, 2025

/azp run

@JamesNK JamesNK enabled auto-merge (squash) January 14, 2025 02:27
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK merged commit 0f8b4c1 into main Jan 14, 2025
@JamesNK JamesNK deleted the jamesnk/fix-resource-filter branch January 14, 2025 03:24
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants