Skip to content

Don't throw if the docker file or context does not exist#7165

Merged
davidfowl merged 1 commit intomainfrom
davidfowl/dont-throw-for-dockerfile
Jan 20, 2025
Merged

Don't throw if the docker file or context does not exist#7165
davidfowl merged 1 commit intomainfrom
davidfowl/dont-throw-for-dockerfile

Conversation

@davidfowl
Copy link
Copy Markdown
Contributor

Description

That creation could be deferred, and the annotation can be overridden.

Fixes #7157

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

- That creation could be deferred and the annotation can be overridden

Fixes #7157
@davidfowl
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually better to fail at the point of read anyway

@davidfowl davidfowl enabled auto-merge (squash) January 20, 2025 19:07
@davidfowl davidfowl merged commit 47ec348 into main Jan 20, 2025
@davidfowl davidfowl deleted the davidfowl/dont-throw-for-dockerfile branch January 20, 2025 19:54
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2025
@github-actions github-actions Bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PublishAsDockerFile throws prematurely if the docker file or docker context is invalid

2 participants