Change CosmosDB Entra Auth to use data plane roles#7245
Merged
davidfowl merged 1 commit intomicrosoft:mainfrom Jan 25, 2025
Merged
Change CosmosDB Entra Auth to use data plane roles#7245davidfowl merged 1 commit intomicrosoft:mainfrom
davidfowl merged 1 commit intomicrosoft:mainfrom
Conversation
We currently use the control plane `DocumentDBAccountContributor` role, which doesn't work to add/update/remove items. Instead of adding the control plane role, assign the data plane contributor role when provisioning the CosmosDB account.
eerhardt
requested review from
Pilchie,
captainsafia,
Copilot,
davidfowl,
sebastienros and
tg-msft
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (4)
- playground/AzureContainerApps/AzureContainerApps.AppHost/account.module.bicep: Language not supported
- playground/CosmosEndToEnd/CosmosEndToEnd.AppHost/cosmos.module.bicep: Language not supported
- playground/bicep/BicepSample.AppHost/cosmos.module.bicep: Language not supported
- playground/cdk/CdkSample.AppHost/cosmos.module.bicep: Language not supported
davidfowl
approved these changes
Jan 25, 2025
davidfowl
approved these changes
Jan 25, 2025
captainsafia
pushed a commit
that referenced
this pull request
Jan 25, 2025
We currently use the control plane `DocumentDBAccountContributor` role, which doesn't work to add/update/remove items. Instead of adding the control plane role, assign the data plane contributor role when provisioning the CosmosDB account.
github-actions
Bot
added
the
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We currently use the control plane
DocumentDBAccountContributorrole, which doesn't work to add/update/remove items.Instead of adding the control plane role, assign the data plane contributor role when provisioning the CosmosDB account.
Checklist