Ensure AspireStore base path is absolute#7513
Merged
sebastienros merged 4 commits intomainfrom Feb 10, 2025
Merged
Conversation
eerhardt
reviewed
Feb 10, 2025
| { | ||
| ArgumentNullException.ThrowIfNull(basePath); | ||
|
|
||
| if (!Path.IsPathRooted(basePath)) |
Member
There was a problem hiding this comment.
Can we ensure it is rooted when we put it in the AssemblyMetadataAttribute?
Contributor
Author
There was a problem hiding this comment.
Right. I realized when the poster explained their value was obj/. I assume in the aspire solution we rewrite it for the artifacts folder. But the default for external project is obj/ as per documentation.
Does the change seem right? I tested it with different values.
eerhardt
reviewed
Feb 10, 2025
…gets Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
eerhardt
reviewed
Feb 10, 2025
Contributor
Author
|
/cc @DamianEdwards in case you also need paths to be absolute in the code you did |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add better error message when the AspireStore base path is invalid
c.f. #7511
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):