Skip to content

Fix FileNotFoundException usage#7540

Merged
danmoseley merged 1 commit intomainfrom
sebros/filenotfound
Feb 12, 2025
Merged

Fix FileNotFoundException usage#7540
danmoseley merged 1 commit intomainfrom
sebros/filenotfound

Conversation

@sebastienros
Copy link
Copy Markdown
Contributor

Description

Wrong string format used in exception message.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Copy Markdown
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is because it does

foobar
File name: 'baz'

@danmoseley danmoseley merged commit 6adbbba into main Feb 12, 2025
@danmoseley danmoseley deleted the sebros/filenotfound branch February 12, 2025 00:32
@sebastienros
Copy link
Copy Markdown
Contributor Author

@danmoseley how I found about it: I wanted to test the copilot logs, so I wrote "how can I improve this class" and it came up with interpolation, then it made me dig ...

@github-actions github-actions Bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants