Add metrics overflow warning to the dashboard#7784
Conversation
There was a problem hiding this comment.
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Aspire.Dashboard/Otlp/Model/OtlpInstrument.cs:31
- Consider adding unit tests for HasOverflowDimension to cover scenarios with dimensions that do and do not contain the overflow attribute, ensuring correct behavior in both cases.
public static bool HasOverflowDimension(List<DimensionScope> dimensions)
cijothomas
left a comment
There was a problem hiding this comment.
Thanks for continuously adding more OpenTelemetry features to Aspire! ❤️
As far as I know, this capability doesn’t exist anywhere else, not even in Prometheus/Grafana.
Great to see Aspire leading the way!
(I plan to showcase this in a tutorial/blog about Cardinality Capping in OTel)
If it's shown off in tutorials/blogs then I'll put a little more effort into styling. I've updated it to look better. |
Description
Fixes #7520
I didn't spend any time styling the warning. Most people will never see this so IMO it's not important we make it look perfect.New:

Old:

Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):