Skip to content

Add metrics overflow warning to the dashboard#7784

Merged
JamesNK merged 8 commits intomainfrom
jamesnk/metrics-overflow-warning
Feb 27, 2025
Merged

Add metrics overflow warning to the dashboard#7784
JamesNK merged 8 commits intomainfrom
jamesnk/metrics-overflow-warning

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Feb 26, 2025

Description

Fixes #7520

I didn't spend any time styling the warning. Most people will never see this so IMO it's not important we make it look perfect.

New:
image

Old:
image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/Aspire.Dashboard/Otlp/Model/OtlpInstrument.cs:31

  • Consider adding unit tests for HasOverflowDimension to cover scenarios with dimensions that do and do not contain the overflow attribute, ensuring correct behavior in both cases.
public static bool HasOverflowDimension(List<DimensionScope> dimensions)

Comment thread playground/Stress/Stress.ApiService/Program.cs
@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Feb 26, 2025

cc @samsp-msft @cijothomas

Comment thread src/Aspire.Dashboard/Otlp/Model/OtlpInstrument.cs Outdated
Comment thread playground/Stress/Stress.ApiService/Program.cs
Copy link
Copy Markdown

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continuously adding more OpenTelemetry features to Aspire! ❤️
As far as I know, this capability doesn’t exist anywhere else, not even in Prometheus/Grafana.
Great to see Aspire leading the way!

(I plan to showcase this in a tutorial/blog about Cardinality Capping in OTel)

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Feb 26, 2025

Thanks for continuously adding more OpenTelemetry features to Aspire! ❤️ As far as I know, this capability doesn’t exist anywhere else, not even in Prometheus/Grafana. Great to see Aspire leading the way!

(I plan to showcase this in a tutorial/blog about Cardinality Capping in OTel)

If it's shown off in tutorials/blogs then I'll put a little more effort into styling. I've updated it to look better.

@JamesNK JamesNK merged commit f31a50f into main Feb 27, 2025
@JamesNK JamesNK deleted the jamesnk/metrics-overflow-warning branch February 27, 2025 23:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Metric Overflow warning if the metric is flagged in OTel data

4 participants