Skip to content

[CI] Fix pipeline tests on rolling builds#8333

Merged
radical merged 7 commits intomicrosoft:mainfrom
radical:fix-pipeline-tests
Mar 27, 2025
Merged

[CI] Fix pipeline tests on rolling builds#8333
radical merged 7 commits intomicrosoft:mainfrom
radical:fix-pipeline-tests

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented Mar 26, 2025

Use $(VSTestNoBuild) property which is used by vstest instead of
arbitrary $(TestNoBuild). VSTest prevents a build of the test projects
when the property is true.

This fixes the running tests on Azdo pipeline builds by not skipping the test projects completely when -testnobuild is used.

Fixes #8330 .

Use `$(VSTestNoBuild)` property which is used by vstest instead of
arbitrary `$(TestNoBuild)`. VSTest prevents a build of the test projects
when the property is `true`.

This fixes the running tests on Azdo pipeline builds.

Fixes microsoft#8330 .
@github-actions github-actions bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Mar 26, 2025
@radical radical requested review from RussKie and joperezr March 26, 2025 22:43
@radical radical marked this pull request as ready for review March 26, 2025 23:25
Copilot AI review requested due to automatic review settings March 26, 2025 23:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • eng/Build.props: Language not supported
  • eng/build.ps1: Language not supported
  • eng/build.sh: Language not supported

radical added 2 commits March 26, 2025 19:26
build scripts's `-testnobuild` is relevant only when `-test` is being
used, and it avoids invoking build on the test projects before running
them.

But `$(SkipTestProjects)` allows skipping test projects from being
included in the build at all. This is useful for cases like when we are
just building the packages, and don't need to build the test projects.
@radical
Copy link
Copy Markdown
Member Author

radical commented Mar 27, 2025

@RussKie
Copy link
Copy Markdown
Contributor

RussKie commented Mar 27, 2025

Use $(VSTestNoBuild) property which is used by vstest instead of
arbitrary $(TestNoBuild). VSTest prevents a build of the test projects
when the property is true.

👍
Sadly, this property doesn't appear to be documented anywhere, but it's part of Microsoft.TestPlatform.targets.

@RussKie
Copy link
Copy Markdown
Contributor

RussKie commented Mar 27, 2025

I don't believe -testnobuild is needed after #8302. Previously running build.cmd -test would be equivalent to running build.cmd -restore -build -test. Now it will only run tests.

@radical
Copy link
Copy Markdown
Member Author

radical commented Mar 27, 2025

I don't believe -testnobuild is needed after #8302. Previously running build.cmd -test would be equivalent to running build.cmd -restore -build -test. Now it will only run tests.

Are you suggesting to drop the parameter completely?

@radical radical enabled auto-merge (squash) March 27, 2025 01:29
@radical radical requested a review from eerhardt as a code owner March 27, 2025 02:19
@radical radical merged commit 3bed084 into microsoft:main Mar 27, 2025
164 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Pipeline tests not running at all on the rolling builds

3 participants