Remember resource filter states

[adamint]

Description

Remembers the disabled states in this page. Moves string escape/unescape functions to StringUtils.

Fixes #3647

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Is this introducing a breaking change?
      • Yes
        • Link to aspire-docs issue (please use this breaking-change template):
      • No
        • Link to aspire-docs issue (please use this doc-idea template):
  • No

[Copilot]

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Aspire.Dashboard/Utils/DashboardUrls.cs:19

• The URL base no longer starts with a leading slash as it used to ($"/{ResourcesBasePath}"). This may cause issues with URL resolution; consider reintroducing the '/' prefix if required for proper routing.

var url = ResourcesBasePath;

[JamesNK]

Adding a filter causes the Resources menu option to not be selected:

This was working (e.g. you could select Graph and it would still be selected) but is broken in your PR.

[JamesNK]

What happens if a value (type, state, health state) contains a space?

Why did you change from comma to space?

[adamint]

What happens if a value (type, state, health state) contains a space?

The space is serialized to a +. Then, when appending to the URL, QueryHelpers.AddQueryString will escape the + to %2B. Reverse process happens when reading from the query param.

Why did you change from comma to space?

I noticed that this was the only instance where a space was not being used to separate separate filters. In telemetry filters, space is used in the URL.

[adamint]

Adding a filter causes the Resources menu option to not be selected:

This was working (e.g. you could select Graph and it would still be selected) but is broken in your PR.

Fixed, thanks

[JamesNK]

Resource filters are in the querystring when returning to the resources pages, but they aren't used:

Test all the scenarios where you could add/remove filters, and navigate to and from the resources page, e..g between table and graph, graph and another page, another page back to graph, table to another page, etc, etc

[JamesNK]

Seems this is tricky to get right. Are component tests needed here to avoid regressions?

[adamint]

Seems this is tricky to get right. Are component tests needed here to avoid regressions?

I added one to simulate the tricky case (navigation to base path, then filters are added to the url, then parameters update and filters should be applied). Do you think it's sufficient?

[adamint]

@JamesNK