Skip to content

Do not override test log output#8774

Merged
RussKie merged 1 commit intomicrosoft:mainfrom
RussKie:fix_xunit_logger
Apr 15, 2025
Merged

Do not override test log output#8774
RussKie merged 1 commit intomicrosoft:mainfrom
RussKie:fix_xunit_logger

Conversation

@RussKie
Copy link
Copy Markdown
Contributor

@RussKie RussKie commented Apr 15, 2025

Currently the test output stomps over the existing log. Restoring the correct behaviour.
Add a new line for better presentation (by adding a space).

Before

image

After

image

@RussKie RussKie requested review from Youssef1313 and radical April 15, 2025 00:34
@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 15, 2025
@RussKie RussKie added area-engineering-systems infrastructure helix infra engineering repo stuff and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 15, 2025
@radical
Copy link
Copy Markdown
Member

radical commented Apr 15, 2025

How does this work with two consecutive runs between which the log file is not removed? Or is it?

@RussKie
Copy link
Copy Markdown
Contributor Author

RussKie commented Apr 15, 2025

How does this work with two consecutive runs between which the log file is not removed? Or is it?

The logs get removed here:
https://github.com/dotnet/aspire/blob/3fc603bdd765bea1c0d9ebb1f7ba5351f4031903/eng/Xunit3/Microsoft.Testing.Platform.targets#L50

@RussKie RussKie merged commit d6da884 into microsoft:main Apr 15, 2025
174 checks passed
@RussKie RussKie deleted the fix_xunit_logger branch April 15, 2025 05:56
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants