Add hidden to protocol, support in dashboard#9069
Conversation
| repeated ResourceRelationship relationships = 20; | ||
|
|
||
| // Whether the resource should be visually hidden in the dashboard. | ||
| bool hidden = 21; |
There was a problem hiding this comment.
I don't think we want a tri state bool.
IMO a resource is hidden if hidden property is true or the state is hidden (for backwards compatibility).
|
@adamint I'm working on a copy of your branch integrating the changes I just merged to main and its looking like the dashboard resource is showing up in the dashboard even though the Hidden field is set to true. Are we not filtering on that flag yet in the PR? |
JamesNK
left a comment
JamesNK
left a comment
There was a problem hiding this comment.
All other bool properties follow is_xxx naming standard.
dotnet-policy-service
Bot
added
the
needs-author-action
|
@adamint please confirm that this works for the dashboard resource. |
The hidden field is only set if the AppHost launch profile doesn't set |
dotnet-policy-service
Bot
removed
the
needs-author-action
| return app.ResourceNotifications.WaitForResourceAsync(resourceName, targetState, cancellationToken); | ||
| } | ||
|
|
||
| #pragma warning disable CS0618 // Type or member is obsolete |
There was a problem hiding this comment.
nit: can you place these just around KnownResourceStates.Hidden in the method instead of the entire method
|
Looking good! |
4 participants
Description
First part of #9063, adds the
hiddenattribute and consumes it in the dashboard. @mitchdennyChecklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate