Don't clobber env files#9161
Merged
Merged
Conversation
- Env files aren't check into source control and overwriting them destroys the values. - This change makes the env file updates purely additive (non existing new keys), and never overwrites or deleted values. - Added tests
github-actions
Bot
added
the
area-integrations
JamesNK
reviewed
May 8, 2025
sebastienros
reviewed
May 8, 2025
|
|
||
| foreach (var line in File.ReadAllLines(path)) | ||
| { | ||
| envFile._lines.Add(line); |
Contributor
There was a problem hiding this comment.
Instead of keeping track of all lines, why not just append to the file if there are lines to add?
sebastienros
reviewed
May 8, 2025
sebastienros
approved these changes
May 8, 2025
danmoseley
reviewed
May 8, 2025
This was referenced May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9124
Checklist