Fix commands left in a disabled state#9383
Merged
danmoseley merged 3 commits intomainfrom May 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Swaps Func<Task> parameters for Blazor EventCallback to ensure UI state refreshes after callbacks complete.
- Changed
AddMenuItemssignatures and invocations to useEventCallback<T>andInvokeAsync. - Updated callers in Razor components to create
EventCallbackviaEventCallback.Factory. - Adjusted unit tests to supply
EventCallback.Empty.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/.../ResourceMenuItemsTests.cs | Replaced dummy Func<Task> args with EventCallback.Empty. |
| src/.../Model/ResourceMenuItems.cs | Changed parameters to EventCallback<T> and updated OnClick. |
| src/.../Resources.razor.cs | Created callbacks with EventCallback.Factory.Create<...>. |
| src/.../ConsoleLogs.razor.cs | Wrapped navigation lambda into EventCallback. |
| src/.../ResourceActions.razor.cs | Passed EventCallback props directly instead of .InvokeAsync. |
Member
|
ignore markdownlint |
8a99231 to
5f672c3
Compare
adamint
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I think this issue is caused by UI state not updating because of the delay. Fix is to switch to using
EventCallbackrather than func.EventCallbackwill always update state after it has finished running.Fixes #8815
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate