Merged
Conversation
Prompted by: ``` /home/runner/work/aspire/aspire/eng/Versions.targets(49,67): error MSB4057: The target "GitInfo" does not exist in the project. [/home/runner/work/aspire/aspire/src/Aspire.AppHost.Sdk/Aspire.RuntimeIdentifier.Tool/Aspire.RuntimeIdentifier.Tool.csproj] ```
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue encountered during the build process where the "GitInfo" target was missing by modifying the CI environment variable setup in the GitHub workflow.
- Added an env block to set CI to false before building the solution.
- Prevents GitInfo errors during the build.
Comments suppressed due to low confidence (1)
.github/workflows/copilot-setup-steps.yml:21
- [nitpick] Setting CI to false in this step helps avoid GitInfo errors, but consider verifying that this change doesn't inadvertently affect other CI-dependent operations. If possible, limit the scope of this override to only the necessary command.
env:
mitchdenny
approved these changes
May 20, 2025
Member
|
When I ran |
Member
Author
Member
Author
|
Merging without waiting for the tests workflow because this change only affects the copilot setup steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by: