More logging in flaky pause console logs test#9435
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances logging and improves test robustness for the console logs pause/resume functionality.
- Updated the UI test to use WaitForElement and WaitForAssertion to help address test flakiness.
- Added detailed debug logging in the console logs component during log load and pause/resume state changes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Dashboard.Components.Tests/Pages/ConsoleLogsTests.cs | Updated test to properly wait for UI elements and assert pause state changes. |
| src/Aspire.Dashboard/Components/Pages/ConsoleLogs.razor.cs | Added debug logs to provide better traceability when loading logs and updating pause state. |
We mark any flaky tests with As for when to get them out of quarantine, I have been doing when there have been >100 passing runs. But that some of the dashboard tests failed after enabling them. Note: there is a difference in how the quarantined tests are run. For a given test assembly, only the quarantined tests in that are run, instead of all the tests in the assembly. Quarantined tests workflow - https://github.com/dotnet/aspire/actions/workflows/tests-outerloop.yml |
|
Should I leave the attribute on the flaky test method and it will be removed later? |
|
ping @adamint review please |
Addresses #9214
@radical What's the process on fixing flaky tests? Do we leave them as flaky and check later to see if there are failures? If so, how do I do that?