Skip to content

Sorting data in table view#10

Merged
emishra merged 1 commit intomainfrom
users/esmishra/summary-table-sort
Jul 7, 2022
Merged

Sorting data in table view#10
emishra merged 1 commit intomainfrom
users/esmishra/summary-table-sort

Conversation

@emishra
Copy link
Contributor

@emishra emishra commented Jul 7, 2022

  1. Store sorted column key and sort direction in local state
  2. Set onSort function as onColumnClick handler
  3. Add default sort function for columns with string data

@emishra emishra requested a review from cr-chinmaya July 7, 2022 01:18
cr-chinmaya
cr-chinmaya approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@cr-chinmaya cr-chinmaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emishra emishra merged commit b528a8e into main Jul 7, 2022
@emishra emishra deleted the users/esmishra/summary-table-sort branch July 7, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cr-chinmaya cr-chinmaya cr-chinmaya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emishra @cr-chinmaya