Create a common abstraction for storing message threads in teams #6243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Created a standard interface, `MessageStore`, for all message store implementations - Created `MemoryMessageStore`, an in-memory implementation of the standard interface, that stores messages in a Python list with timestamps.
ekzhu
reviewed
Apr 10, 2025
|
|
||
| @property | ||
| @abstractmethod | ||
| def ttl(self) -> Optional[float]: |
Contributor
There was a problem hiding this comment.
I think this should be in the concrete class not in the base class, something you can set as part of the constructor.
| pass | ||
|
|
||
| @abstractmethod | ||
| async def add_messages(self, messages: List[BaseChatMessage]) -> None: |
Contributor
There was a problem hiding this comment.
It should be BaseChatMessage | BaseAgentEvent to be consistent with how message threads are implemented as list in BaseGroupChatManager.
| from ...messages import BaseChatMessage | ||
|
|
||
|
|
||
| class MessageStore(ABC): |
Contributor
There was a problem hiding this comment.
It should have save_state and load_state methods to be used together with the agent classes.
Also, it should subclass Component to enable serializable component config.
Contributor
There was a problem hiding this comment.
See example in autogen_core.mode_context.ChatCompletionContext.
Contributor
|
Work is happening in #6350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
MessageStoreabstract base class for storing message thread in teams andMemoryMessageStorea memory (thread-safe) memory implementation of the abstract class that uses a timestamp-based time to live (TTL) to handle message expiration.To Do to complete this PR:
Why are these changes needed?
Define correctly and rigorously how messages should be stored and handled in teams.
Related issue number
Closes #6227
Checks