Skip to content

Conversation

@ShyamSathish005
Copy link
Contributor

Fixes #6234

Update test_filesurfer_agent.py to handle valid directory paths.

  • Add test_open_path_valid_directory test to verify that FileSurfer can read a valid directory without returning FileNotFoundError.
  • Mock API calls and create a test directory for the new test case.
  • Validate that the FileSurfer agent correctly reads the directory and returns the expected content.

ShyamSathish005 and others added 2 commits April 11, 2025 11:41
Fixes microsoft#6234

Update `test_filesurfer_agent.py` to handle valid directory paths.

* Add `test_open_path_valid_directory` test to verify that `FileSurfer` can read a valid directory without returning `FileNotFoundError`.
* Mock API calls and create a test directory for the new test case.
* Validate that the `FileSurfer` agent correctly reads the directory and returns the expected content.
Copy link
Contributor

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this fix #6234

@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (3425d7d) to head (79d24a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6275   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files         200      200           
  Lines       14322    14322           
=======================================
  Hits        11068    11068           
  Misses       3254     3254           
Flag Coverage Δ
unittests 77.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileSurfer in Magentic-One no longer able to find or list files after 0.5.1 update. Keeps returning FileNotFoundError

2 participants