fix(autogen-ext): clean up temporary output dir in JupyterCodeExecutor#7226
Closed
weiguangli-io wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix(autogen-ext): clean up temporary output dir in JupyterCodeExecutor#7226weiguangli-io wants to merge 1 commit intomicrosoft:mainfrom
weiguangli-io wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
Closing — the autogen repo has shifted to maintenance mode and external PRs are no longer being reviewed. Thank you for the great framework! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a resource leak in JupyterCodeExecutor when output_dir is not provided.
Closes #7217.
Problem
JupyterCodeExecutor creates a temporary output directory by default, but stop() did not clean it up. In long-running/local-dev workflows this leaves temp directories behind.
Changes
Validation
Local checks run and passed:
Coverage for autogen_ext.code_executors.jupyter._jupyter_code_executor in this test run: 100%.