Fix MagenticOne handoff resume context reset and document expected HITL behavior (#7036)#7378
Open
kowshik24 wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
…and update documentation
Author
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
MagenticOneGroupChatwas not preserving context across human-in-the-loop handoff resumes.After
HandoffTermination(target="user"), a follow-uprun()/run_stream(task=...)call was treated as a new task becauseMagenticOneOrchestrator.handle_startrebuilt task/ledger state each time.This PR fixes that behavior so resumes continue from preserved context (matching expected HITL semantics), adds a regression test,
and updates docs to clarify expected behavior.
What changed
MagenticOneOrchestrator.handle_start:test_magentic_one_handoff_resume_preserves_contextMagenticOneGroupChatpreserves context across handoff resumes.Related issue number
Closes #7036
Checks
Local validation run:
uv run --project python pytest -q packages/autogen-agentchat/tests/test_magentic_one_group_chat.py(passed)uv run --project python ruff checkon modified src/test files (passed)