Reading package.json fails when using in VS code extension

[cschleiden]

When using the API in a vscode extension, package.json is not available, and creation of an API fails.

As a sidenote: as a user I was very surprised that an http client library tries to read files from the disk, is that really necessary? The library should know its version without doing that.

[damccorm]

This has been fixed, see #244 - we will republish soon. And I don't know of a good way to get the library without reading from the package.json or hardcoding it, certainly open to suggestions and/or PRs though.

[cschleiden]

Why don't you encode the version when building?

[damccorm]

I'm not 100% sure what you mean - do you mean hardcoding it, reading the value and storing it somewhere while building, or something else?

Not sure if this is actually a big deal for this library, it needs to read files in other places too anyways(admittedly only for certain configurations)

[cschleiden]

It's about being predicable. I hadn't used our node API package before, and when I saw the error message about package.json not being found I would have never guessed - without debugging - that the error was caused by the API client.

If you need the version of the API package, we should hardcode it during the build in make.sh. Basically have some const and replace its value with the version from this repo's package.json.