Add samples #213
Merged
Add samples #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2018 13:44
samples/wiki.ts
Outdated
| const textStream: NodeJS.ReadableStream = await wikiApiObject.getPageText(project, wikiId) | ||
| console.log("Wiki text", textStream.read().toString()); | ||
|
|
||
| if (wikis.length == 0) { |
Member
There was a problem hiding this comment.
Length is 0 then we try to delete? Should be !==?
Author
There was a problem hiding this comment.
No, I think this is correct logic because we only want to delete a wiki if we created one (otherwise we're deleting their actual wiki), and we only want to create a wiki if they don't already have one (otherwise it will fail). With that said, the code clarity is not great, I've updated to hopefully be more clear
samples/wiki.ts
Outdated
|
|
||
| if (wikis.length == 0) { | ||
| common.heading("Delete the created wiki"); | ||
| await wikiApiObject.deleteWiki(wikiId, project); |
Member
There was a problem hiding this comment.
Check response if there is one and print it.
samples/wiki.ts
Outdated
| } | ||
|
|
||
| common.heading("Get the text from a wiki"); | ||
| const textStream: NodeJS.ReadableStream = await wikiApiObject.getPageText(project, wikiId) |
Member
There was a problem hiding this comment.
Rename variable to pageText
samples/wiki.ts
Outdated
|
|
||
| export async function run() { | ||
| let webApi: nodeApi.WebApi = await common.getWebApi(); | ||
| let wikiApiObject: WikiApi.IWikiApi = await webApi.getWikiApi(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added samples for Git and Wiki. Probably could be developed more (in particular Git), but this is at least a good starting place.