Skip to content

Conversation

stephenmichaelf
Copy link
Member

No description provided.

Copy link

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be good to merge this in, want to resolve the conflict and merge?

@damccorm damccorm mentioned this pull request Dec 7, 2018
@joaomoreno
Copy link
Member

Ping @stephenmichaelf

@stephenmichaelf
Copy link
Member Author

@joaomoreno Are you able to verify from this PR that it fixes what you need? Let me fix merge conflicts and we can merge.

@joaomoreno
Copy link
Member

@stephenmichaelf At a glance, it appears to contain all features required by VSCE.

@stephenmichaelf
Copy link
Member Author

Thanks for the quick response, I will get this merged today.

@joaomoreno
Copy link
Member

joaomoreno commented Jan 7, 2019

@stephenmichaelf Also microsoft/vscode-vsce#318 would require exposing the unpublishExtension call, which doesn't seem to be exposed in this PR. It wasn't exposed before as well, but it would be a great addition to this API.

@damccorm
Copy link

damccorm commented Jan 7, 2019

@stephenmichaelf I went ahead and fixed the conflicts, I'll merge as well.

@joaomoreno let's merge this as-is for now and handle unpublishExtension in a separate PR. I'll create an issue and follow up there.

@joaomoreno
Copy link
Member

@stephenmichaelf Can we release a new version with these changes? https://www.npmjs.com/package/azure-devops-node-api

@stephenmichaelf
Copy link
Member Author

@bryanmacfarlane Could we release?

@bryanmacfarlane
Copy link
Contributor

done

  • azure-devops-node-api@7.2.0

@stephenmichaelf
Copy link
Member Author

@joaomoreno FYI this is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants