Skip to content

Enable retries #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 1 commit into from
Mar 21, 2019
Merged

Enable retries #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion api/WebApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,12 @@ export class WebApi {

// TODO: Don't call resource area here? Will cause infinite loop?
public async getLocationsApi(serverUrl?: string, handlers?: VsoBaseInterfaces.IRequestHandler[]): Promise<locationsm.ILocationsApi> {
let optionsClone: VsoBaseInterfaces.IRequestOptions = Object.assign({}, this.options);
optionsClone.allowRetries = true;
optionsClone.maxRetries = 5;
serverUrl = await serverUrl || this.serverUrl;
handlers = handlers || [this.authHandler];
return new locationsm.LocationsApi(serverUrl, handlers, this.options);
return new locationsm.LocationsApi(serverUrl, handlers, optionsClone);
}

public async getNotificationApi(serverUrl?: string, handlers?: VsoBaseInterfaces.IRequestHandler[]): Promise<notificationm.INotificationApi> {
Expand Down
10 changes: 6 additions & 4 deletions api/interfaces/common/VsoBaseInterfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,12 @@ export interface IHttpClientResponse {
}

export interface IRequestOptions {
socketTimeout?: number,
ignoreSslError?: boolean,
proxy?: IProxyConfiguration
cert?: ICertConfiguration
socketTimeout?: number;
ignoreSslError?: boolean;
proxy?: IProxyConfiguration;
cert?: ICertConfiguration;
allowRetries?: boolean;
maxRetries?: number;
}

export interface IProxyConfiguration {
Expand Down
116 changes: 58 additions & 58 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "azure-devops-node-api",
"description": "Node client for Azure DevOps and TFS REST APIs",
"version": "7.1.0",
"version": "7.2.0",
"main": "./WebApi.js",
"types": "./WebApi.d.ts",
"scripts": {
Expand All @@ -26,7 +26,7 @@
"dependencies": {
"os": "0.1.1",
"tunnel": "0.0.4",
"typed-rest-client": "1.0.9",
"typed-rest-client": "1.2.0",
"underscore": "1.8.3"
},
"devDependencies": {
Expand Down