WebApi.ts new NtlmCredetialHandler initialization was wrong order#70
Merged
bryanmacfarlane merged 2 commits intomicrosoft:masterfrom Mar 29, 2017
alpersogukpinar:master
Merged
WebApi.ts new NtlmCredetialHandler initialization was wrong order#70bryanmacfarlane merged 2 commits intomicrosoft:masterfrom alpersogukpinar:master
bryanmacfarlane merged 2 commits intomicrosoft:masterfrom
alpersogukpinar:master
Conversation
WebApi.ts new NtlmCredetialHandler initializatin was wrong at line39. workstation and domain order parameters were reverse order. But it is exported in that order, that's why I changed the constructor according to this.
Update ntlm.ts for
Contributor
|
reviewing ... sorry for the delay here. |
Contributor
|
Thanks @alpersogukpinar. We can verify this change before the next release (it seems correct enough). Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebApi.ts new NtlmCredetialHandler initialization was wrong order at line39. workstation and domain order parameters are being set in reverse order.
Because it is exported in that order at WebApi.ts, I changed the constructor signature in ntlm.ts instead of changing WebApits
Fix #69