Skip to content

don't need Q anymore #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryanmacfarlane merged 2 commits into from
Jun 5, 2017
Merged

don't need Q anymore #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f916c8
don't need Q anymore
scottdallamura Jun 5, 2017
d115676
fix comment
scottdallamura Jun 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions api/GalleryCompatHttpClientBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

// Licensed under the MIT license. See LICENSE file in the project root for full license information.


import Q = require('q');
import * as restm from 'typed-rest-client/RestClient';
import * as httpm from 'typed-rest-client/HttpClient';
import vsom = require('./VsoClient');
Expand Down
3 changes: 1 addition & 2 deletions api/WebApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ export function getPersonalAccessTokenHandler(token) {

// ---------------------------------------------------------------------------
// Factory to return client apis
// When new APIs are added, two methods must be added here to instantiate the
// API and its corresponding Q Promise-wrapped API
// When new APIs are added, a method must be added here to instantiate the API
//----------------------------------------------------------------------------
export class WebApi {

Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vso-node-api",
"description": "Node client for Visual Studio Online/TFS REST APIs",
"version": "6.2.2-preview",
"version": "6.2.3-preview",
"main": "./WebApi.js",
"typings": "./WebApi.d.ts",
"scripts": {
Expand All @@ -21,7 +21,6 @@
],
"license": "MIT",
"dependencies": {
"q": "^1.0.1",
"tunnel": "0.0.4",
"typed-rest-client": "^0.10.0",
"underscore": "^1.8.3"
Expand Down
10 changes: 5 additions & 5 deletions samples/task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import * as Q from 'q';
import * as fs from 'fs';
import * as path from 'path';
import * as stream from 'stream';
Expand Down Expand Up @@ -31,11 +30,12 @@ export async function run() {
let taskDefinition = tasks[0];
let file: NodeJS.WritableStream = fs.createWriteStream(sampleFilePath);
let stream = (await vstsTask.getTaskContentZip(taskDefinition.id, `${taskDefinition.version.major}.${taskDefinition.version.minor}.${taskDefinition.version.patch}`)).pipe(file);
let defer = Q.defer();
stream.on('finish', () => {
defer.resolve();
let promise = new Promise((resolve, reject) => {
stream.on('finish', () => {
resolve();
});
});
await defer.promise;
await promise;
console.log(`Downloaded task ${taskDefinition.name}`);
}

Expand Down