fix: disallow release bumping on decimal releases#138
Merged
reubeno merged 2 commits intomicrosoft:mainfrom Apr 30, 2026
Merged
fix: disallow release bumping on decimal releases#138reubeno merged 2 commits intomicrosoft:mainfrom
reubeno merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR prevents BumpStaticRelease from bumping releases that use dotted/decimal-style numeric prefixes (e.g., 1.39.b1), where the leading integer is not the build counter.
Changes:
- Tightened the static release regex to reject values where the leading integer is immediately followed by a dot.
- Added test cases asserting dotted/decimal-ish releases are rejected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/app/azldev/core/sources/release.go | Updates staticReleasePattern to reject dotted numeric prefixes in static Release values. |
| internal/app/azldev/core/sources/release_test.go | Adds regression tests ensuring dotted/decimal-style Release values are rejected. |
Tonisal-byte
force-pushed
the
asalinas/nonautorelease-fix-0429
branch
from
c63109c to
eeb5edd
Compare
reubeno
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes resolve the unintended behavior of bumping the leading integer in decimal releases that exist in some specs. One such example occurs with the package
cvsps.