fix: filter noise from license checks#230
Merged
Merged
Conversation
37a2319 to
e5ab83e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces noise from go-licenses by filtering out benign “contains non-Go code that can't be inspected” glog warnings (and their continuation path lines), only surfacing remaining output when the license command fails.
Changes:
- Added reusable filtering/printing helpers in
mageutilfor suppressing known-benigngo-licenseswarning blocks. - Updated the license check (
go-licenses check) to capture combined output and print only filtered output on failure. - Updated the license report/save paths to capture stderr, filter benign warnings, and only print remaining stderr output on failure.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
magefiles/mageutil/mageutil.go |
Adds FilterLicenseNoise and PrintLicenseOutput helpers to remove known-benign go-licenses warning blocks. |
magefiles/magecheckfix/checkfix.go |
Refactors license check/report to capture output and suppress benign warnings unless a command fails. |
magefiles/magebuild/magebuild.go |
Captures go-licenses save stderr to suppress benign warnings unless license collection fails. |
reubeno
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter out: