feat(config): rename publish channel field to publish-channel and PublishChannel#96
Merged
reubeno merged 2 commits intomicrosoft:mainfrom Apr 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR standardizes the “publish channel” naming across the config model, CLI JSON outputs, generated schema, tests, and user docs by renaming the field from channel to publishChannel / PublishChannel, and the TOML key to publish-channel.
Changes:
- Renames the Go config field to
PublishChanneland updates TOML/JSON tags accordingly. - Updates CLI result structs and JSON payload fields from
channeltopublishChannel. - Updates generated JSON schema/snapshots and documentation examples to use
publish-channelin TOML.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| schemas/azldev.schema.json | Renames schema property/title for the publish channel field. |
| scenario/snapshots/TestSnapshots_config_generate-schema_stdout_1.snap | Updates schema snapshot to match renamed property/title. |
| scenario/snapshots/TestSnapshotsContainer_config_generate-schema_stdout_1.snap | Updates container schema snapshot to match renamed property/title. |
| internal/projectconfig/package.go | Renames config struct field and updates TOML/JSON/schema tags. |
| internal/projectconfig/package_test.go | Updates unit tests for renamed field and validator message expectations. |
| internal/projectconfig/loader_test.go | Updates TOML parsing tests to the new publish-channel key and field name. |
| internal/app/azldev/cmds/pkg/list.go | Renames CLI list result field and JSON/table output naming. |
| internal/app/azldev/cmds/pkg/list_test.go | Updates CLI list tests for renamed result field. |
| internal/app/azldev/cmds/component/build.go | Renames RPM publish-channel field used in build results and move logic. |
| internal/app/azldev/cmds/component/build_test.go | Updates build tests for renamed RPM result field. |
| docs/user/reference/config/project.md | Updates TOML examples to publish-channel. |
| docs/user/reference/config/package-groups.md | Updates TOML key in docs (table + examples) to publish-channel. |
| docs/user/reference/config/components.md | Updates TOML examples to publish-channel. |
| docs/user/how-to/inspect-package-config.md | Updates JSON output example key to publishChannel. |
dmcilvaney
reviewed
Apr 14, 2026
| // Currently only publish settings are supported; additional fields may be added in the future. | ||
| type PackageConfig struct { | ||
| // Publish holds the publish settings for this package. | ||
| Publish PackagePublishConfig `toml:"publish,omitempty" json:"publish,omitempty" jsonschema:"title=Publish settings,description=Publishing settings for this binary package" fingerprint:"-"` |
Contributor
There was a problem hiding this comment.
Fingerprint is ignored here, so identity should be good.
dmcilvaney
approved these changes
Apr 14, 2026
- azldev package list: JSON key 'channel' -> 'publishChannel', table header 'CHANNEL' -> 'PUBLISH CHANNEL' - azldev component build: JSON key 'channel' -> 'publishChannel', table header 'Channel' -> 'Publish Channel' (per-RPM result); table header 'Channels' -> 'Publish Channels' (per-component summary) - Update inspect-package-config.md doc examples to match
liunan-ms
force-pushed
the
liunan/publish-channel
branch
from
7a558c5 to
663f723
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the naming of the publish channel field from
channeltopublish-channelin JSON and table output:channel->publishChannel,table header
CHANNEL->PUBLISH CHANNELchannel->publishChannel,table header
Channel->Publish Channel(per-RPM result);table header
Channels->Publish Channels(per-component summary)