Skip to content

Conversation

@joscol
Copy link
Contributor

@joscol joscol commented Apr 24, 2019

detect when badly formed YAML causes the multi-document error and then give an error on an individual line instead of flagging the entire file.

See: microsoft/azure-pipelines-vscode#219

@joscol joscol requested review from jayspadie and rsemenov April 24, 2019 21:13
Copy link
Member

@jayspadie jayspadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. I assume the document.errors aren't localized, so we can reliably match "end of the stream or a document separator is expected"?

@joscol
Copy link
Contributor Author

joscol commented Apr 25, 2019

@jayspadie I didn't see anything in throwError that looked it like it would localize the error

yaml_end_of_stream_error

@joscol joscol merged commit cee43a8 into master Apr 25, 2019
@vtbassmatt vtbassmatt deleted the users/joscol/219_multi_doc branch January 19, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants