Skip to content

Remove driver check for ADFT#674

Merged
04diiguyi merged 1 commit intomainfrom
adamgrofe/bugfix/driver_check
May 19, 2025
Merged

Remove driver check for ADFT#674
04diiguyi merged 1 commit intomainfrom
adamgrofe/bugfix/driver_check

Conversation

@adam-grofe
Copy link
Copy Markdown
Contributor

In the bug bash today, we found a bug where the chemistry team added a new driver (polarizability) but we couldn't submit a job because the SDK checks for supported drivers. Based on discussions with David, it sounds like they plan on adding a lot more drivers in the future so I think it is better to remove the check on the SDK side. Regardless, this parameter is validated on the API side. This was done to fail early but now it seems like it will inhibit the dev process more than help.

@adam-grofe adam-grofe requested a review from a team as a code owner May 19, 2025 20:15
@adam-grofe
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@04diiguyi 04diiguyi merged commit 6d63d9c into main May 19, 2025
6 checks passed
@04diiguyi 04diiguyi deleted the adamgrofe/bugfix/driver_check branch May 19, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants