Skip to content

Fix provider id for targets with non-standard provider ids #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

Fix provider id for targets with non-standard provider ids #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a1df0d
Fix provider id for targets with non-standard provider ids
xinyi-joffre Sep 26, 2025
dcf380a
Remove warning message since dynamic providers should be supported
xinyi-joffre Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion azure-quantum/azure/quantum/target/target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def __repr__(self):

@classmethod
def from_target_status(
cls, workspace: "Workspace", status: TargetStatus, **kwargs
cls, workspace: "Workspace", provider_id: str, status: TargetStatus, **kwargs
):
"""Create a Target instance from a given workspace and target status.

Expand All @@ -131,6 +131,7 @@ def from_target_status(
return cls(
workspace=workspace,
name=status.id,
provider_id=provider_id,
average_queue_time=status.average_queue_time,
current_availability=status.current_availability,
**kwargs
Expand Down
6 changes: 1 addition & 5 deletions azure-quantum/azure/quantum/target/target_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ def _target_cls(self, provider_id: str, name: str):
if provider_id.lower() in self._default_targets:
return self._default_targets[provider_id.lower()]

warnings.warn(
f"No default target specified for provider {provider_id}. \
Please check the provider name and try again or create an issue here: \
https://github.com/microsoft/qdk-python/issues.")
return Target

def create_target(
Expand Down Expand Up @@ -105,7 +101,7 @@ def from_target_status(
):
cls = self._target_cls(provider_id, status.id)
if hasattr(cls, "from_target_status"):
return cls.from_target_status(self._workspace, status, **kwargs)
return cls.from_target_status(self._workspace, provider_id, status, **kwargs)
elif cls is not None:
return cls(name=status.id, **kwargs)

Expand Down
Loading