Allow override of quantum endpoint for data plane #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
04diiguyi
approved these changes
Oct 27, 2025
kikomiss
reviewed
Oct 27, 2025
| _endpoint = endpoint | ||
| print("Overrided endpoint: ", _endpoint) | ||
| else: | ||
| _endpoint = "https://{region}.{serviceBaseUrl}" |
Collaborator
There was a problem hiding this comment.
Does not this need to be _endpoint = f"https://{region}.{service_base_url}"?
Collaborator
Author
There was a problem hiding this comment.
No, it gets formatted within service client. This is just the base pattern that will get replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the logic to override quantum_endpoint is broken, this fixes it so that data plane calls actually use the overridden endpoint. We need this for testing the new data plane v2 endpoint.
workspace = Workspace(resource_id= "",
location="",
quantum_endpoint="https://quantum.azure.com/"
)