Fix error when doing password hashing for aarch64 offline image builds#10111
Merged
dmcilvaney merged 3 commits intomicrosoft:3.0-devfrom Aug 12, 2024
Merged
Conversation
anphel31
approved these changes
Aug 12, 2024
PawelWMS
reviewed
Aug 12, 2024
jslobodzian
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
In https://github.com/microsoft/azurelinux/pull/9037/files#diff-4399971797c1c0942b710773d3f583fb0c697de6dd1edc655a5b80e4e1f79462R169 we accidentally dropped the
opensslcommand line tools from the chroot environment. This won't have affected most packages since they will be usingopenssl-devel, or have explicitBuildRequires: openssl, but it DOES affect offline image build (since that uses the chroot as an isolation layer). A call toopenssl passwd ...to hash a plain-text password from the user would fail withexec: "openssl": executable file not found in $PATH. (But only for aarch64, we installgrub2-pcazurelinux/toolkit/tools/imagegen/installutils/installutils.go
Line 114 in 0f0a7df
This may have some unexpected impacts on packages! While I believe the impact will be fairly minor, I cannot exclude the possibility that some packages may run
./configureor similar and detect the absence/presence of theopensslcommand line tool without having an explicit build requirement for it.Change Log
opensslto the chrootDoes this affect the toolchain?
YES (sort of, the implicit build dependencies provided by the chroot can have big knock-on affects).
Associated issues
Test Methodology