Skip to content

Enable --tui on perf command#10281

Closed
AZaugg wants to merge 3 commits intomicrosoft:3.0-devfrom
AZaugg:3.0-perf-tui
Closed

Enable --tui on perf command#10281
AZaugg wants to merge 3 commits intomicrosoft:3.0-devfrom
AZaugg:3.0-perf-tui

Conversation

@AZaugg
Copy link
Copy Markdown
Contributor

@AZaugg AZaugg commented Aug 28, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

We had a request to allow perf --tui to work, looking at Make config in perf
https://github.com/torvalds/linux/blob/928f79a188aacc057ba36c85b36b6d1e99c8f595/tools/perf/Makefile.config#L818 looks like slang-devel is needed, adding it to the build requires to get this going

Change Log
  • Adding slang-devel to Build requires to allow perf to work in --tui
Does this affect the toolchain?

YES

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Still in testing

@AZaugg AZaugg requested a review from a team as a code owner August 28, 2024 23:51
@mfrw mfrw added the 3.0-dev PRs Destined for AzureLinux 3.0 label Aug 29, 2024
Comment thread SPECS/kernel/kernel.spec Outdated
Name: kernel
Version: 6.6.47.1
Release: 1%{?dist}
Release: 2%{?dist}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to change a few more files to keep the spec and others at lock-step:
Representational PR:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was kinda unsure if that was required. I looked at and saw that the kernel headers are maintained separately.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily our PR checks have caught it :)
image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfrw Updated the PR

@AZaugg AZaugg requested a review from a team as a code owner September 4, 2024 19:34
@AZaugg AZaugg requested a review from a team as a code owner September 4, 2024 19:38
@AZaugg
Copy link
Copy Markdown
Contributor Author

AZaugg commented Mar 10, 2025

Resolved in #12820

@AZaugg AZaugg closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants