Enable --tui on perf command#10281
Closed
AZaugg wants to merge 3 commits intomicrosoft:3.0-devfrom
AZaugg:3.0-perf-tui
Closed
Enable --tui on perf command#10281AZaugg wants to merge 3 commits intomicrosoft:3.0-devfrom AZaugg:3.0-perf-tui
AZaugg wants to merge 3 commits intomicrosoft:3.0-devfrom
AZaugg:3.0-perf-tui
Conversation
mfrw
reviewed
Aug 29, 2024
| Name: kernel | ||
| Version: 6.6.47.1 | ||
| Release: 1%{?dist} | ||
| Release: 2%{?dist} |
Member
There was a problem hiding this comment.
We would need to change a few more files to keep the spec and others at lock-step:
Representational PR:
Contributor
Author
There was a problem hiding this comment.
I was kinda unsure if that was required. I looked at and saw that the kernel headers are maintained separately.
Member
Contributor
Author
|
Resolved in #12820 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
We had a request to allow perf --tui to work, looking at Make config in perf
https://github.com/torvalds/linux/blob/928f79a188aacc057ba36c85b36b6d1e99c8f595/tools/perf/Makefile.config#L818 looks like slang-devel is needed, adding it to the build requires to get this going
Change Log
Does this affect the toolchain?
YES
Associated issues
Links to CVEs
Test Methodology