Skip to content

Fixed nghttp2 test-time dependency on CUnit.#10289

Merged
PawelWMS merged 1 commit into3.0-devfrom
pawelwi/cunit_dep_fix
Aug 29, 2024
Merged

Fixed nghttp2 test-time dependency on CUnit.#10289
PawelWMS merged 1 commit into3.0-devfrom
pawelwi/cunit_dep_fix

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS commented Aug 29, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

In 3.0 we've modified the toolkit to not ignore the casing of the package dependencies. This is by design and it broke test builds for nghttp2, which declares a dependency on cunit, where in reality the package is called CUnit. Fixing this here.

Does this affect the toolchain?

Yes.

Test Methodology

@PawelWMS PawelWMS requested review from a team as code owners August 29, 2024 20:26
@PawelWMS PawelWMS merged commit a878f87 into 3.0-dev Aug 29, 2024
@PawelWMS PawelWMS deleted the pawelwi/cunit_dep_fix branch August 29, 2024 20:55
anphel31 pushed a commit that referenced this pull request Aug 30, 2024
PawelWMS added a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants