Skip to content

fix ocaml test issues#10298

Merged
anphel31 merged 1 commit into3.0-devfrom
anphel/3-fix-fasttrack-tests
Aug 30, 2024
Merged

fix ocaml test issues#10298
anphel31 merged 1 commit into3.0-devfrom
anphel/3-fix-fasttrack-tests

Conversation

@anphel31
Copy link
Copy Markdown
Member

@anphel31 anphel31 commented Aug 30, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Fix missing dependencies when running tests with ocaml packages.

Change Log
  • ocaml-base: remove unneeded test dependencies
  • ocaml-cinaps: disable check section
  • ocaml-sexplib: remove unneeded test dependencies
Does this affect the toolchain?

NO

Associated issues
Test Methodology

@anphel31 anphel31 merged commit 538e181 into 3.0-dev Aug 30, 2024
@anphel31 anphel31 deleted the anphel/3-fix-fasttrack-tests branch August 30, 2024 06:47
PawelWMS pushed a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants