Cdi Shared Server Binary#10382
Merged
Adub17030MS merged 21 commits into3.0-devfrom Oct 22, 2024
Merged
Conversation
23ffd83 to
3a2ca74
Compare
romoh
approved these changes
Oct 22, 2024
anphel31
approved these changes
Oct 22, 2024
durgajagadeesh
pushed a commit
to durgajagadeesh/azurelinux_djpalli
that referenced
this pull request
Dec 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
CDI rpm build needs to be able to build the
cdi-containerimage-serverbinary asnot a dynamic executable. Currently, it is being built as adynamically linkedbinary, which causes k8s VM cloning issues for our tests and Nexus. The changes in this pr modify the go build flags to enable this desired behavior.Change Log
CGO_ENABLED=0to disable Cgo, ensuring fully static binaries.-buildmode=pieforcdi-containerimage-serverbuild, which previously enabled dynamic linking behavior.These changes guarantee that the
cdi-containerimage-serverbinary is statically linked and does not depend on any external shared libraries at runtime.Does this affect the toolchain?
NO
Associated issues
https://dev.azure.com/mariner-org/ECF/_workitems/edit/8682
Links to CVEs
Test Methodology