Skip to content

Conversation

@anphel31
Copy link
Member

@anphel31 anphel31 commented Sep 10, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Include the release information in the version field of the embedded ELF module metadata.
Before:

$ readelf --notes /usr/bin/tree | grep "description data" | sed -e "s/\s*description data: //g" -e "s
/ //g" | xxd -p -r | jq
{
  "moduleVersion": "1.8.0.0",
  "name": "tree",
  "os": "mariner",
  "osVersion": "3.0",
  "type": "rpm",
  "version": "1.8.0"
}

After:

$ readelf --notes /usr/bin/tree | grep "description data" | sed -e "s/\s*description data: //g" -e "s
/ //g" | xxd -p -r | jq
{
  "moduleVersion": "1.8.0.0",
  "name": "tree",
  "os": "mariner",
  "osVersion": "3.0",
  "type": "rpm",
  "version": "1.8.0-3.azl3"
}
Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES

Associated issues
Test Methodology

@anphel31 anphel31 marked this pull request as ready for review September 10, 2024 23:29
@anphel31 anphel31 requested review from a team as code owners September 10, 2024 23:29
@anphel31 anphel31 merged commit 016977a into 3.0-dev Sep 13, 2024
@anphel31 anphel31 deleted the anphel/3-ld-script-version-release branch September 13, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants