Skip to content

Backport CVE-2024-3727 fix for libcontainers-common#10432

Merged
PawelWMS merged 2 commits intofasttrack/2.0from
sudipta/cve-2024-3727-libcontainers-fasttrack2.0
Sep 13, 2024
Merged

Backport CVE-2024-3727 fix for libcontainers-common#10432
PawelWMS merged 2 commits intofasttrack/2.0from
sudipta/cve-2024-3727-libcontainers-fasttrack2.0

Conversation

@realsdx
Copy link
Copy Markdown
Contributor

@realsdx realsdx commented Sep 12, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Upstream fix for CVE-2024-3727 was incompatible with the containers/image package vendored in this package.
The patch differs significantly from the upstream, also have two different versions of containers/image vendored` ( podmand has older version).

Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: Link

@realsdx realsdx marked this pull request as ready for review September 13, 2024 12:38
@realsdx realsdx requested a review from a team as a code owner September 13, 2024 12:38
Copy link
Copy Markdown
Contributor

@rikenm1 rikenm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PawelWMS PawelWMS merged commit a731dba into fasttrack/2.0 Sep 13, 2024
@PawelWMS PawelWMS deleted the sudipta/cve-2024-3727-libcontainers-fasttrack2.0 branch September 13, 2024 18:05
CBL-Mariner-Bot pushed a commit that referenced this pull request Sep 13, 2024
@CBL-Mariner-Bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants