Skip to content

toolkit: scripts: use '#!/usr/bin/env python3' instead of hardcoding interpreter#10471

Merged
mfrw merged 1 commit into3.0-devfrom
mfrw/update-python
Sep 18, 2024
Merged

toolkit: scripts: use '#!/usr/bin/env python3' instead of hardcoding interpreter#10471
mfrw merged 1 commit into3.0-devfrom
mfrw/update-python

Conversation

@mfrw
Copy link
Copy Markdown
Member

@mfrw mfrw commented Sep 17, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Use python interpreter as #!/bin/env python3 instead of hardcoding.
This helps in levarging virtualenvs for scripts and not disturbing the systemd wide python installation

Change Log
Does this affect the toolchain?

NO

Associated issues
  • NA
Links to CVEs
  • NA
Test Methodology
  • Local Testing of the scripts

…interpreter

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@mfrw mfrw marked this pull request as ready for review September 17, 2024 18:21
@mfrw mfrw requested a review from a team as a code owner September 17, 2024 18:21
@mfrw mfrw added the 3.0-dev PRs Destined for AzureLinux 3.0 label Sep 18, 2024
@mfrw mfrw merged commit f0151c1 into 3.0-dev Sep 18, 2024
@mfrw mfrw deleted the mfrw/update-python branch September 18, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants