Skip to content

kata-containers(-cc): Use build recipes from sources#10527

Merged
manuelh-dev merged 6 commits into3.0-devfrom
mahuber/kata-spec-rebuild-squash-m3-pr
Oct 23, 2024
Merged

kata-containers(-cc): Use build recipes from sources#10527
manuelh-dev merged 6 commits into3.0-devfrom
mahuber/kata-spec-rebuild-squash-m3-pr

Conversation

@manuelh-dev
Copy link
Copy Markdown
Contributor

@manuelh-dev manuelh-dev commented Sep 23, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

This commit simplifies package and UVM build by using recipes established in our sources. These recipes also make shipping separate UVM build scripts obsolete. The UVMs can from now on be built standalone using the kata-containers-(cc-)tools subpackages

Change Log
  • Use build recipes from fork
Does this affect the toolchain?

NO

Associated issues
  • N/A
Links to CVEs
  • N/A
Test Methodology
  • buddy build runs
  • image build and AKS end-to-end test pipeline run
  • manual package deployment and manual deployment of Kata pods

Comment thread SPECS/kata-containers-cc/kata-containers-cc.spec
Comment thread SPECS/kata-containers-cc/kata-containers-cc.signatures.json Outdated
Comment thread SPECS/kata-containers-cc/kata-containers-cc.spec
Comment thread SPECS/kata-packages-uvm/kata-packages-uvm.spec
This commit simplifies package and UVM build by using
recipes established in our sources. These recipes also
make shipping separate UVM build scripts obsolete. The
UVMs can from now on be built standalone using the
kata-containers-(cc-)tools subpackages

Signed-off-by: Manuel Huber <mahuber@microsoft.com>
@manuelh-dev manuelh-dev force-pushed the mahuber/kata-spec-rebuild-squash-m3-pr branch from 1196f3f to 196350f Compare September 27, 2024 00:38
@manuelh-dev manuelh-dev marked this pull request as ready for review October 3, 2024 18:59
@manuelh-dev manuelh-dev requested review from a team as code owners October 3, 2024 18:59
Copy link
Copy Markdown
Collaborator

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments to fix but changes generally LGTM

Comment thread SPECS/kata-containers-cc/kata-containers-cc.signatures.json Outdated
Comment thread SPECS/kata-containers-cc/kata-containers-cc.spec
Comment thread SPECS/kata-containers-cc/kata-containers-cc.spec
Comment thread SPECS/kata-containers-cc/kata-containers-cc.spec Outdated
Comment thread SPECS/kata-containers/kata-containers.spec Outdated
manuelh-dev and others added 3 commits October 15, 2024 16:06
Co-authored-by: Christopher Co <35273088+christopherco@users.noreply.github.com>
Co-authored-by: Christopher Co <35273088+christopherco@users.noreply.github.com>
@manuelh-dev manuelh-dev requested a review from a team as a code owner October 15, 2024 23:08
@manuelh-dev manuelh-dev merged commit e2b58d9 into 3.0-dev Oct 23, 2024
@manuelh-dev manuelh-dev deleted the mahuber/kata-spec-rebuild-squash-m3-pr branch October 23, 2024 03:53
durgajagadeesh pushed a commit to durgajagadeesh/azurelinux_djpalli that referenced this pull request Dec 31, 2024
Signed-off-by: Manuel Huber <mahuber@microsoft.com>
Co-authored-by: Saul Paredes <30801614+Redent0r@users.noreply.github.com>
Co-authored-by: Christopher Co <35273088+christopherco@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants