Skip to content

Enable virtio console by default and build e1000 drivers as modules#10604

Merged
rlmenge merged 2 commits into3.0-devfrom
rlmenge/3.0/lsg/e1000
Oct 3, 2024
Merged

Enable virtio console by default and build e1000 drivers as modules#10604
rlmenge merged 2 commits into3.0-devfrom
rlmenge/3.0/lsg/e1000

Conversation

@rlmenge
Copy link
Copy Markdown
Contributor

@rlmenge rlmenge commented Oct 2, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Enable virtio console by default - Kconfig
Because we typically service a hypervised environment, load virtio console by default.
More on virtio: https://docs.kernel.org/driver-api/virtio/virtio.html

Make the e1000 x86 configs modules instead of built-in - Kconfig
These drivers are specific for one type of ethernet adapter. Therefore make a module and not built-in by default. The module will be called e1000

Change Log
  • Make the e1000 x86 configs modules instead of built-in
  • Enable virtio console by default
Does this affect the toolchain?

YES

Associated issues
Test Methodology
image

@rlmenge rlmenge force-pushed the rlmenge/3.0/lsg/e1000 branch from f17f876 to 25d41d6 Compare October 3, 2024 00:57
@rlmenge rlmenge marked this pull request as ready for review October 3, 2024 00:59
@rlmenge rlmenge requested review from a team as code owners October 3, 2024 00:59
@rlmenge rlmenge merged commit f086246 into 3.0-dev Oct 3, 2024
@rlmenge rlmenge deleted the rlmenge/3.0/lsg/e1000 branch October 3, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants