Fixed toolkit's handling of RPMs with epoch values in their name#10629
Merged
Fixed toolkit's handling of RPMs with epoch values in their name#10629
Conversation
jslobodzian
approved these changes
Oct 4, 2024
anphel31
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Continuation of #10587
We've recently started seeing builds failing with following errors:
This seems to be related with invalid parsing of the
tdnf providesoutput where the tool's regex failed to take a potential:into the account. A few lines above the mentioned error, we can see TDNF finding the right package:The
:character in2:7.70-506.azl3.noarchis what confused the regex.The current (as of 09/30/2024) version of TDNF (3.5.6) is printing the versions without the epoch and that's why we haven't hit this issue until now. It seems that the bump to version 3.5.8 added the epoch number to the
tdnf providesoutput.Sample output for 3.5.6:
Notice no epoch in
7.70-506.azl3.noarch.Does this affect the toolchain?
No.
Test Methodology