Skip to content

Added directory check before cleaning-up the RPM caches.#10800

Merged
PawelWMS merged 1 commit intofasttrack/3.0from
pawelwi/snapshot_fix
Oct 21, 2024
Merged

Added directory check before cleaning-up the RPM caches.#10800
PawelWMS merged 1 commit intofasttrack/3.0from
pawelwi/snapshot_fix

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

This is a fix-up for #10756. We've missed doing a check for the existence of the searched directory before running find.

Does this affect the toolchain?

No.

Associated issues
Test Methodology
  • Local builds.

Copy link
Copy Markdown
Contributor

@sameluch sameluch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@PawelWMS
Copy link
Copy Markdown
Contributor Author

Only known flaky tests failing, merging.

@CBL-Mariner-Bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants