Skip to content

Add Valkey Container#11156

Merged
xordux merged 2 commits into3.0-devfrom
rohit/valkey-container
Jan 16, 2025
Merged

Add Valkey Container#11156
xordux merged 2 commits into3.0-devfrom
rohit/valkey-container

Conversation

@xordux
Copy link
Copy Markdown
Contributor

@xordux xordux commented Nov 20, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Add valkey container for 3.0 branch.

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Build Pipeline [link]
  • Test Pipeline [link]

@xordux xordux marked this pull request as ready for review December 19, 2024 17:16
@xordux xordux requested a review from a team as a code owner December 19, 2024 17:16
@xordux xordux added 3.0-dev PRs Destined for AzureLinux 3.0 Container labels Dec 19, 2024
Copy link
Copy Markdown
Contributor

@rikenm1 rikenm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a comment

Copy link
Copy Markdown

@LeoMar4 LeoMar4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xordux xordux merged commit 31c66a0 into 3.0-dev Jan 16, 2025
@xordux xordux deleted the rohit/valkey-container branch January 16, 2025 05:38
SumitJenaHCL pushed a commit to SumitJenaHCL/azurelinux that referenced this pull request Jan 28, 2025
SumitJenaHCL pushed a commit to SumitJenaHCL/azurelinux that referenced this pull request Feb 24, 2025
KavyaSree2610 pushed a commit to KavyaSree2610/azurelinux that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Container

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants