Skip to content

Cache clean-up fix.#11249

Merged
PawelWMS merged 2 commits into3.0-devfrom
pawelwi/fix_snapshot_clean-up
Dec 9, 2024
Merged

Cache clean-up fix.#11249
PawelWMS merged 2 commits into3.0-devfrom
pawelwi/fix_snapshot_clean-up

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS commented Nov 28, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Update to #10369.

The original change made the toolkit always clean-up the downloaded RPMs cache, even if the repo snapshot flag was not set. This broke scenarios, where a use pre-populates the cache with hydrate-cached-rpms. Now the cache will only be cleaned-up if the PACKAGE_CACHE_SUMMARY or REPO_SNAPSHOT_TIME flag is set. Running with PACKAGE_CACHE_SUMMARY is another scenario, where we need to purge the cache before we run the package fetcher.

Does this affect the toolchain?

No.

Associated issues
Test Methodology

@PawelWMS PawelWMS requested a review from a team as a code owner November 28, 2024 04:26
Comment thread toolkit/scripts/pkggen.mk Outdated
@PawelWMS PawelWMS merged commit abf249d into 3.0-dev Dec 9, 2024
@PawelWMS PawelWMS deleted the pawelwi/fix_snapshot_clean-up branch December 9, 2024 18:56
arc9693 pushed a commit that referenced this pull request Dec 12, 2024
aditjha-msft pushed a commit that referenced this pull request Dec 18, 2024
durgajagadeesh pushed a commit to durgajagadeesh/azurelinux_djpalli that referenced this pull request Dec 31, 2024
durgajagadeesh pushed a commit to durgajagadeesh/azurelinux_djpalli that referenced this pull request Dec 31, 2024
aninda-al pushed a commit to aninda-al/azurelinux-test that referenced this pull request Jan 3, 2025
SumitJenaHCL pushed a commit to SumitJenaHCL/azurelinux that referenced this pull request Feb 24, 2025
KavyaSree2610 pushed a commit to KavyaSree2610/azurelinux that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants